Why is vertcat slowing things down?

3 vues (au cours des 30 derniers jours)
Doron
Doron le 23 Fév 2012
Modifié(e) : Matt J le 22 Oct 2013
In the code below, 10,000 repetitions takes 2 seconds... and 100,000 repetitions takes 60 seconds! (I was expecting 20 seconds or less)...
What is going on? by a process of elimination, I suspect "vertcat" is slowing things down...
(Please see how "tic toc" behaves with repetitions = 10,000 and 100,000)
Is this a known issue with vertcat? If so, what are my other options?
(Note: looping the 10,000 algorithm 10 times would be much faster... but surely there has to be a more elegant way to do 100,000 repetitions in 20 seconds)
Thanks
Doron
*********
tic
repetitions = 10000
llim = -1;
ulim = 3;
xstack = [];
xlifestack = [];
for i = 1:repetitions
x = 0;
xlife = 0;
while ulim > x && x > llim
x = x + normrnd(0,1);
xlife = xlife + 1; % "...and the walk lives one more step"
end
if x > llim
x = ulim;
else x = llim;
end
xstack = vertcat(xstack, x);
xlifestack = vertcat(xlifestack, xlife);
end
xbar = mean(xstack);
xlifebar = mean(xlifestack);
toc

Réponse acceptée

Honglei Chen
Honglei Chen le 23 Fév 2012
My 2 cents::
1. You may want to preallocate the memory. The in each iteration, you just put the new data into corresponding slots.
2. If your entire purpose is to compute the mean, then why not just record the sum and number of samples and update them for each iteration. These are just scalars.
  8 commentaires
Doron
Doron le 23 Fév 2012
right...
xstack = zeros(100000,1)
%then
for i = 1:repetitions
% x is computed by an algorithm
xstack(i) = x
end
Doron
Doron le 23 Fév 2012
Thanks Oleg and Honglei,
I went with "xstack = (repetitions, 1)"
I don't know which one to accept as the answer, so I flipped a coin...
Thank you both
Doron

Connectez-vous pour commenter.

Plus de réponses (0)

Catégories

En savoir plus sur Performance and Memory dans Help Center et File Exchange

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!

Translated by