vectorizing or speeding looped code

2 vues (au cours des 30 derniers jours)
Paul Schenk le 22 Sep 2020
Commenté : Paul Schenk le 23 Sep 2020
i am trying to speed up some code with multiple functions and have found the one that takes the most time (it is all a converted fortran code). it runs a nested for loop 4 times (each with modified input). i've had some success elsewhere in the code eliminating slow points but this one just cant get right. any ideas? (in 2016b for compatability reasons)
for II= 1:N
XP(1)= 1.0D0;
for JJ=2:IORD1
XP(JJ)=XP(JJ-1)*double(A1(II));
end
for JJ= 1:IORD1
for KK= 1:IORD1
B(JJ,KK)=B(JJ,KK)+XP(JJ)*XP(KK);
end
C(JJ)=C(JJ)+XP(JJ)*A2(II);
end
end
0 commentairesAfficher -1 commentaires plus anciensMasquer -1 commentaires plus anciens

Connectez-vous pour commenter.

Réponses (3)

Turlough Hughes le 22 Sep 2020
This should help, though I've already made assumptions about the sizes of arrays. How many rows/columns are in each variable?
XP(1) = 1;
for II= 1:N
XP(2:end) = XP(1:end-1)*double(A1(II));
B = B + XP(:).*XP(:).';
C = C + XP*A2(II);
end
2 commentairesAfficher 1 commentaire plus ancienMasquer 1 commentaire plus ancien
Turlough Hughes le 22 Sep 2020
Did the code work?
Some questions: is XP a column vector/row vector? Does A2 have as many elements as XP? Also, does B contain IORD1 rows and columns? Similarly does C have IORD1 elements?

Connectez-vous pour commenter.

Paul Schenk le 22 Sep 2020
not as entered. tripled cpu time.
here are preallo's to variables:
ORDER_MAX = 20;
C = zeros(ORDER_MAX+1,1);
IORD=MAXOR;
IORD1=IORD+1;
B = single(zeros(ORDER_MAX+1,ORDER_MAX+1)); % Solution matrix
XP = double(zeros(ORDER_MAX+1,1)); % Array of solutions
2 commentairesAfficher 1 commentaire plus ancienMasquer 1 commentaire plus ancien
Turlough Hughes le 23 Sep 2020
Vectorisation is usually faster but not always. Probably best to just provide a minimum working example (google it) of code that I (or others) can test and profile. Otherwise it really is just guess work.

Connectez-vous pour commenter.

Paul Schenk le 23 Sep 2020
hope this works for you. it is essentially a customized LS fit solution.
4 commentairesAfficher 3 commentaires plus anciensMasquer 3 commentaires plus anciens
Paul Schenk le 23 Sep 2020
yes, my mistake!

Connectez-vous pour commenter.

Catégories

En savoir plus sur Descriptive Statistics and Visualization dans Help Center et File Exchange

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!

Translated by